Rosti/node-api
3
0
Fork 0
Code Issues 2 Pull requests Projects Releases 22 Wiki Activity Actions

Update Makefile to use golang:1.24-bookworm and disable OOM killer in docker.go
Some checks failed
Unittests / deploy-dev (push) Has been cancelled
Details
Unittests / unittests (push) Has been cancelled
Details

Browse source
This commit is contained in:
Adam Štrauch 2026-01-05 16:09:59 +01:00
parent 29a9594ddb
commit 50fb0bec7e
Signed by: cx
GPG key ID: 7262DAFE292BCE20
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Makefile
View file

@ -6,8 +6,8 @@ test:
# env DOCKER_SOCKET="unix:///var/run/docker.sock" go test -v containers/*.go # Doesn't work in Drone right now
build:
#podman run --rm --privileged -ti -v ${shell pwd}:/srv docker.io/library/golang:1.14-stretch /bin/sh -c "cd /srv && go build"
go build -a -ldflags "-linkmode external -extldflags '-static' -s -w"
podman run --rm --privileged -ti -v ${shell pwd}:/srv docker.io/library/golang:1.24-bookworm /bin/sh -c "cd /srv && go build -o node-api-bookworm"
#go build -a -ldflags "-linkmode external -extldflags '-static' -s -w"
.PHONY: minio
minio:

5
containers/docker.go
View file

@ -343,8 +343,9 @@ func (d *Driver) Create(name string, image string, volumePath string, HTTPPort i
// OOMKillDisable = true
// }
// We disable OOM killer because it keeps containers in resource heavy loop
// This is from some discussion: If OOM-killer is disabled, tasks under cgroup will hang/sleep in memory cgroup's OOM-waitqueue when they request accountable memory
OOMKillDisable := true
// This is from some discussion: If OOM-killer is disabled, tasks under cgroup will hang/sleep in memory cgroup's OOM-waitqueue when they request accountable memory.
// Disabling OOM killer kills the whole machine because some kernel processes get under memory pressure and the host system becomes unresponsive.
OOMKillDisable := false
envList := []string{}
for key, value := range env {